Explorar o código

Fix github authentication request, fixes #5767

Jordi Boggiano %!s(int64=7) %!d(string=hai) anos
pai
achega
1933532ec5
Modificáronse 1 ficheiros con 3 adicións e 1 borrados
  1. 3 1
      src/Composer/Repository/Vcs/GitHubDriver.php

+ 3 - 1
src/Composer/Repository/Vcs/GitHubDriver.php

@@ -361,7 +361,9 @@ class GitHubDriver extends VcsDriver
                         }
                     }
                     $scopesFailed = array_diff($scopesNeeded, $scopesIssued);
-                    if (!$headers || count($scopesFailed)) {
+                    // non-authenticated requests get no scopesNeeded, so ask for credentials
+                    // authenticated requests which failed some scopes should ask for new credentials too
+                    if (!$headers || !count($scopesNeeded) || count($scopesFailed)) {
                         $gitHubUtil->authorizeOAuthInteractively($this->originUrl, 'Your GitHub credentials are required to fetch private repository metadata (<info>'.$this->url.'</info>)');
                     }