Jordi Boggiano 11 years ago
parent
commit
1dd8bffce5

+ 10 - 2
src/Composer/Command/InitCommand.php

@@ -490,8 +490,16 @@ EOT
 
     protected function isValidEmail($email)
     {
-        if (!function_exists('filter_var')) return true; // Bypass if we can't validate it
-        if (version_compare(PHP_VERSION, '5.3.3', '<')) return true; // ?
+        // assume it's valid if we can't validate it
+        if (!function_exists('filter_var')) {
+            return true;
+        }
+
+        // php <5.3.3 has a very broken email validator, so bypass checks
+        if (version_compare(PHP_VERSION, '5.3.3', '<')) {
+            return true;
+        }
+
         return false !== filter_var($email, FILTER_VALIDATE_EMAIL);
     }
 }

+ 10 - 0
tests/Composer/Test/AllFunctionalTest.php

@@ -1,5 +1,15 @@
 <?php
 
+/*
+ * This file is part of Composer.
+ *
+ * (c) Nils Adermann <naderman@naderman.de>
+ *     Jordi Boggiano <j.boggiano@seld.be>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 namespace Composer\Test;
 
 use Symfony\Component\Process\Process;

+ 10 - 0
tests/Composer/Test/Command/InitCommandTest.php

@@ -1,5 +1,15 @@
 <?php
 
+/*
+ * This file is part of Composer.
+ *
+ * (c) Nils Adermann <naderman@naderman.de>
+ *     Jordi Boggiano <j.boggiano@seld.be>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 namespace Composer\Test\Command;
 
 use Composer\Command\InitCommand;

+ 1 - 0
tests/Composer/Test/ComposerTest.php

@@ -1,4 +1,5 @@
 <?php
+
 /*
  * This file is part of Composer.
  *

+ 1 - 0
tests/Composer/Test/InstallerTest.php

@@ -1,4 +1,5 @@
 <?php
+
 /*
  * This file is part of Composer.
  *