Browse Source

Merge pull request #5992 from AnrDaemon/fix-git-skips-proper

Properly skip GitDownloaderTest if git is not available
Jordi Boggiano 8 years ago
parent
commit
2782d37a15
1 changed files with 2 additions and 11 deletions
  1. 2 11
      tests/Composer/Test/Downloader/GitDownloaderTest.php

+ 2 - 11
tests/Composer/Test/Downloader/GitDownloaderTest.php

@@ -25,19 +25,10 @@ class GitDownloaderTest extends TestCase
     /** @var string */
     private $workingDir;
 
-    private $skipped;
-
-    protected function initialize()
-    {
-        try {
-            $this->skipIfNotExecutable('git');
-        } catch (\PHPUnit_Framework_SkippedTestError $e) {
-            $this->skipped = 'This test needs a git binary in the PATH to be able to run';
-        }
-    }
-
     protected function setUp()
     {
+        $this->skipIfNotExecutable('git');
+
         $this->fs = new Filesystem;
         $this->workingDir = $this->getUniqueTmpDirectory();
     }