瀏覽代碼

Move public properties to top and document them

Nils Adermann 10 年之前
父節點
當前提交
5c0efdcaa2
共有 2 個文件被更改,包括 17 次插入3 次删除
  1. 10 2
      src/Composer/DependencyResolver/Rule.php
  2. 7 1
      src/Composer/Package/BasePackage.php

+ 10 - 2
src/Composer/DependencyResolver/Rule.php

@@ -29,6 +29,16 @@ class Rule
     const RULE_LEARNED = 12;
     const RULE_PACKAGE_ALIAS = 13;
 
+    /**
+     * The literals this rule consists of.
+     *
+     * Each element is a package id either positive for installation or
+     * negative meaning removal.
+     *
+     * @var array
+     */
+    public $literals;
+
     protected $pool;
 
     protected $disabled;
@@ -41,8 +51,6 @@ class Rule
 
     protected $ruleHash;
 
-    public $literals;
-
     public function __construct(Pool $pool, array $literals, $reason, $reasonData, $job = null)
     {
         $this->pool = $pool;

+ 7 - 1
src/Composer/Package/BasePackage.php

@@ -44,13 +44,19 @@ abstract class BasePackage implements PackageInterface
         'dev'    => self::STABILITY_DEV,
     );
 
+    /**
+     * The package id, public for fast access in dependency solver
+     * Use getId() unless called extremely frequently.
+     * @var int
+     */
+    public $id;
+
     protected $name;
     protected $prettyName;
 
     protected $repository;
     protected $transportOptions;
 
-    public $id;
 
     /**
      * All descendants' constructors should call this parent constructor