Browse Source

use array as default value

rather than assigning empty array in constructor. the latter can cause
issues with mocks in some scenarios (if constructor does not get called)
Rob Bast 8 years ago
parent
commit
611d6a0364
1 changed files with 5 additions and 4 deletions
  1. 5 4
      src/Composer/Package/BasePackage.php

+ 5 - 4
src/Composer/Package/BasePackage.php

@@ -49,12 +49,14 @@ abstract class BasePackage implements PackageInterface
      * @var int
      * @var int
      */
      */
     public $id;
     public $id;
-
+    /** @var string */
     protected $name;
     protected $name;
+    /** @var string */
     protected $prettyName;
     protected $prettyName;
-
+    /** @var RepositoryInterface */
     protected $repository;
     protected $repository;
-    protected $transportOptions;
+    /** @var array */
+    protected $transportOptions = array();
 
 
     /**
     /**
      * All descendants' constructors should call this parent constructor
      * All descendants' constructors should call this parent constructor
@@ -66,7 +68,6 @@ abstract class BasePackage implements PackageInterface
         $this->prettyName = $name;
         $this->prettyName = $name;
         $this->name = strtolower($name);
         $this->name = strtolower($name);
         $this->id = -1;
         $this->id = -1;
-        $this->transportOptions = array();
     }
     }
 
 
     /**
     /**