浏览代码

Merge pull request #5785 from nicolas-grekas/perf

Enhance performance by removing count() from Solver's main loop
Nils Adermann 8 年之前
父节点
当前提交
66efc9af86
共有 1 个文件被更改,包括 5 次插入2 次删除
  1. 5 2
      src/Composer/DependencyResolver/Solver.php

+ 5 - 2
src/Composer/DependencyResolver/Solver.php

@@ -758,8 +758,10 @@ class Solver
                 $systemLevel = $level;
                 $systemLevel = $level;
             }
             }
 
 
-            for ($i = 0, $n = 0; $n < count($this->rules); $i++, $n++) {
-                if ($i == count($this->rules)) {
+            $rulesCount = count($this->rules);
+
+            for ($i = 0, $n = 0; $n < $rulesCount; $i++, $n++) {
+                if ($i == $rulesCount) {
                     $i = 0;
                     $i = 0;
                 }
                 }
 
 
@@ -805,6 +807,7 @@ class Solver
                 }
                 }
 
 
                 // something changed, so look at all rules again
                 // something changed, so look at all rules again
+                $rulesCount = count($this->rules);
                 $n = -1;
                 $n = -1;
             }
             }