Эх сурвалжийг харах

Define variable only when actually used

Markus Staab 6 жил өмнө
parent
commit
86d5de2965

+ 1 - 2
src/Composer/DependencyResolver/Solver.php

@@ -510,9 +510,8 @@ class Solver
      */
      */
     private function analyzeUnsolvableRule(Problem $problem, Rule $conflictRule)
     private function analyzeUnsolvableRule(Problem $problem, Rule $conflictRule)
     {
     {
-        $why = spl_object_hash($conflictRule);
-
         if ($conflictRule->getType() == RuleSet::TYPE_LEARNED) {
         if ($conflictRule->getType() == RuleSet::TYPE_LEARNED) {
+            $why = spl_object_hash($conflictRule);
             $learnedWhy = $this->learnedWhy[$why];
             $learnedWhy = $this->learnedWhy[$why];
             $problemRules = $this->learnedPool[$learnedWhy];
             $problemRules = $this->learnedPool[$learnedWhy];