Browse Source

Simplified the code

Christophe Coevoet 12 years ago
parent
commit
9e372b1d8b

+ 0 - 4
src/Composer/Installer.php

@@ -190,10 +190,6 @@ class Installer
         foreach ($this->suggestedPackages as $suggestion) {
             $target = $suggestion['target'];
             if ($installedRepo->filterPackages(function (PackageInterface $package) use ($target) {
-                // check the name first as it is the common case
-                if ($package->getName() === $target) {
-                    return false;
-                }
                 if (in_array($target, $package->getNames())) {
                     return false;
                 }

+ 1 - 1
tests/Composer/Test/Fixtures/installer/suggest-installed.test

@@ -1,5 +1,5 @@
 --TEST--
-Suggestions are not displayed for installed packages if they are also installed
+Suggestions are not displayed for installed packages
 --COMPOSER--
 {
     "repositories": [

+ 1 - 1
tests/Composer/Test/Fixtures/installer/suggest-replaced.test

@@ -1,5 +1,5 @@
 --TEST--
-Suggestions are not displayed for installed packages if they are replaced
+Suggestions are not displayed for packages if they are replaced
 --COMPOSER--
 {
     "repositories": [

+ 1 - 1
tests/Composer/Test/Fixtures/installer/suggest-uninstalled.test

@@ -1,5 +1,5 @@
 --TEST--
-Suggestions are displayed for installed packages
+Suggestions are displayed
 --COMPOSER--
 {
     "repositories": [