Rename and document constants for partial update behavior

src/Composer/Command/RemoveCommand.php

@@ -181,7 +181,7 @@ EOT
             ->setApcuAutoloader($apcu)
             ->setUpdate(true)
             ->setUpdateAllowList($packages)
-            ->setUpdateAllowTransitiveDependencies($input->getOption('no-update-with-dependencies') ? Request::UPDATE_ONLY_LISTED : Request::UPDATE_TRANSITIVE_DEPENDENCIES)
+            ->setUpdateAllowTransitiveDependencies($input->getOption('no-update-with-dependencies') ? Request::UPDATE_ONLY_LISTED : Request::UPDATE_LISTED_WITH_TRANSITIVE_DEPS_NO_ROOT_REQUIRE)
             ->setIgnorePlatformRequirements($input->getOption('ignore-platform-reqs'))
             ->setRunScripts(!$input->getOption('no-scripts'))
             ->setDryRun($dryRun)

src/Composer/Command/RequireCommand.php

@@ -251,9 +251,9 @@ EOT
 
         $updateAllowTransitiveDependencies = Request::UPDATE_ONLY_LISTED;
         if ($input->getOption('update-with-all-dependencies')) {
-            $updateAllowTransitiveDependencies = Request::UPDATE_TRANSITIVE_ROOT_DEPENDENCIES;
+            $updateAllowTransitiveDependencies = Request::UPDATE_LISTED_WITH_TRANSITIVE_DEPS;
         } elseif ($input->getOption('update-with-dependencies')) {
-            $updateAllowTransitiveDependencies = Request::UPDATE_TRANSITIVE_DEPENDENCIES;
+            $updateAllowTransitiveDependencies = Request::UPDATE_LISTED_WITH_TRANSITIVE_DEPS_NO_ROOT_REQUIRE;
         }
 
         $commandEvent = new CommandEvent(PluginEvents::COMMAND, 'require', $input, $output);

src/Composer/Command/UpdateCommand.php

@@ -148,9 +148,9 @@ EOT
 
         $updateAllowTransitiveDependencies = Request::UPDATE_ONLY_LISTED;
         if ($input->getOption('with-all-dependencies')) {
-            $updateAllowTransitiveDependencies = Request::UPDATE_TRANSITIVE_ROOT_DEPENDENCIES;
+            $updateAllowTransitiveDependencies = Request::UPDATE_LISTED_WITH_TRANSITIVE_DEPS;
         } elseif ($input->getOption('with-dependencies')) {
-            $updateAllowTransitiveDependencies = Request::UPDATE_TRANSITIVE_DEPENDENCIES;
+            $updateAllowTransitiveDependencies = Request::UPDATE_LISTED_WITH_TRANSITIVE_DEPS_NO_ROOT_REQUIRE;
         }
 
         $install

src/Composer/DependencyResolver/Request.php

@@ -23,9 +23,22 @@ use Composer\Semver\Constraint\ConstraintInterface;
  */
 class Request
 {
+    /**
+     * Identifies a partial update for listed packages only, all dependencies will remain at locked versions
+     */
     const UPDATE_ONLY_LISTED = 0;
-    const UPDATE_TRANSITIVE_DEPENDENCIES = 1;
-    const UPDATE_TRANSITIVE_ROOT_DEPENDENCIES = 2;
+
+    /**
+     * Identifies a partial update for listed packages and recursively all their dependencies, however dependencies
+     * also directly required by the root composer.json and their dependencies will remain at the locked version.
+     */
+    const UPDATE_LISTED_WITH_TRANSITIVE_DEPS_NO_ROOT_REQUIRE = 1;
+
+    /**
+     * Identifies a partial update for listed packages and recursively all their dependencies, even dependencies
+     * also directly required by the root composer.json will be updated.
+     */
+    const UPDATE_LISTED_WITH_TRANSITIVE_DEPS = 2;
 
     protected $lockedRepository;
     protected $requires = array();
@@ -83,7 +96,7 @@ class Request
 
     public function getUpdateAllowTransitiveRootDependencies()
     {
-        return $this->updateAllowTransitiveDependencies === self::UPDATE_TRANSITIVE_ROOT_DEPENDENCIES;
+        return $this->updateAllowTransitiveDependencies === self::UPDATE_LISTED_WITH_TRANSITIVE_DEPS;
     }
 
     public function getRequires()

src/Composer/Installer.php

@@ -1150,7 +1150,7 @@ class Installer
      */
     public function setUpdateAllowTransitiveDependencies($updateAllowTransitiveDependencies)
     {
-        if (!in_array($updateAllowTransitiveDependencies, array(Request::UPDATE_ONLY_LISTED, Request::UPDATE_TRANSITIVE_DEPENDENCIES, Request::UPDATE_TRANSITIVE_ROOT_DEPENDENCIES), true)) {
+        if (!in_array($updateAllowTransitiveDependencies, array(Request::UPDATE_ONLY_LISTED, Request::UPDATE_LISTED_WITH_TRANSITIVE_DEPS_NO_ROOT_REQUIRE, Request::UPDATE_LISTED_WITH_TRANSITIVE_DEPS), true)) {
             throw new \RuntimeException("Invalid value for updateAllowTransitiveDependencies supplied");
         }
 

tests/Composer/Test/InstallerTest.php

@@ -282,9 +282,9 @@ class InstallerTest extends TestCase
 
             $updateAllowTransitiveDependencies = Request::UPDATE_ONLY_LISTED;
             if ($input->getOption('with-all-dependencies')) {
-                $updateAllowTransitiveDependencies = Request::UPDATE_TRANSITIVE_ROOT_DEPENDENCIES;
+                $updateAllowTransitiveDependencies = Request::UPDATE_LISTED_WITH_TRANSITIVE_DEPS;
             } elseif ($input->getOption('with-dependencies')) {
-                $updateAllowTransitiveDependencies = Request::UPDATE_TRANSITIVE_DEPENDENCIES;
+                $updateAllowTransitiveDependencies = Request::UPDATE_LISTED_WITH_TRANSITIVE_DEPS_NO_ROOT_REQUIRE;
             }
 
             $installer