Ver código fonte

Rule hashes are only used in the rule set, so no need to store them

Nils Adermann 9 anos atrás
pai
commit
c7e1f49e78
1 arquivos alterados com 2 adições e 9 exclusões
  1. 2 9
      src/Composer/DependencyResolver/Rule.php

+ 2 - 9
src/Composer/DependencyResolver/Rule.php

@@ -43,8 +43,6 @@ class Rule
 
     protected $job;
 
-    protected $ruleHash;
-
     public function __construct(array $literals, $reason, $reasonData, $job = null)
     {
         // sort all packages ascending by id
@@ -58,13 +56,12 @@ class Rule
         $this->job = $job;
         $this->type = -1;
 
-        $data = unpack('ihash', md5(implode(',', $this->literals), true));
-        $this->ruleHash = $data['hash'];
     }
 
     public function getHash()
     {
-        return $this->ruleHash;
+        $data = unpack('ihash', md5(implode(',', $this->literals), true));
+        return $data['hash'];
     }
 
     public function setId($id)
@@ -113,10 +110,6 @@ class Rule
      */
     public function equals(Rule $rule)
     {
-        if ($this->ruleHash !== $rule->ruleHash) {
-            return false;
-        }
-
         if (count($this->literals) != count($rule->literals)) {
             return false;
         }