Browse Source

Clean ups after feedback

Jordi Boggiano 12 years ago
parent
commit
e1bd2fd6df

+ 0 - 1
src/Composer/Command/CreateProjectCommand.php

@@ -123,7 +123,6 @@ EOT
 
                     return false;
                 }
-                if ($package->getName() === $name) {var_dump((string) $package);}
             });
         }
 

+ 0 - 2
src/Composer/Command/SearchCommand.php

@@ -63,8 +63,6 @@ EOT
             $repos = new CompositeRepository(array_merge(array($installedRepo), $defaultRepos));
         }
 
-        $time = microtime(true);
-
         $this->tokens = $input->getArgument('tokens');
         $this->output = $output;
         $repos->filterPackages(array($this, 'processPackage'), 'Composer\Package\CompletePackage');

+ 1 - 1
src/Composer/Repository/RepositoryInterface.php

@@ -52,7 +52,7 @@ interface RepositoryInterface extends \Countable
     public function findPackages($name, $version = null);
 
     /**
-     * Filters all the packages throuhg a callback
+     * Filters all the packages through a callback
      *
      * The packages are not guaranteed to be instances in the repository
      * and this can only be used for streaming through a list of packages.

+ 6 - 0
src/Composer/Repository/StreamableRepositoryInterface.php

@@ -23,6 +23,8 @@ interface StreamableRepositoryInterface extends RepositoryInterface
     /**
      * Return partial package data without loading them all to save on memory
      *
+     * The function must return an array of package arrays.
+     *
      * The package array must contain the following fields:
      *  - name: package name (normalized/lowercased)
      *  - repo: reference to the repository instance
@@ -32,6 +34,10 @@ interface StreamableRepositoryInterface extends RepositoryInterface
      *  - alias: pretty alias that this package should be aliased to, optional
      *  - alias_normalized: normalized alias that this package should be aliased to, optional
      *
+     * Any additional information can be returned and will be sent back
+     * into loadPackage/loadAliasPackage for completing the package loading
+     * when it's needed.
+     *
      * @return array
      */
     public function getMinimalPackages();