Ver Fonte

Remove code preventing protocol downgrades

Chris Smith há 9 anos atrás
pai
commit
ffab235edd
1 ficheiros alterados com 9 adições e 8 exclusões
  1. 9 8
      src/Composer/Util/RemoteFilesystem.php

+ 9 - 8
src/Composer/Util/RemoteFilesystem.php

@@ -331,14 +331,15 @@ class RemoteFilesystem
                     throw $e;
                 }
 
-                if ('http' === parse_url($targetUrl, PHP_URL_SCHEME) && 'https' === $this->scheme) {
-                    // Do not allow protocol downgrade.
-                    // TODO: Currently this will fail if a request goes http -> https -> http
-                    $e = new TransportException('The "'.$this->fileUrl.'" file could not be downloaded, not permitting protocol downgrade');
-                    $e->setHeaders($http_response_header);
-                    $e->setResponse($result);
-                    throw $e;
-                }
+                // TODO: Disabled because this is (probably) different behaviour to PHP following for us.
+                // if ('http' === parse_url($targetUrl, PHP_URL_SCHEME) && 'https' === $this->scheme) {
+                //     // Do not allow protocol downgrade.
+                //     // TODO: Currently this will fail if a request goes http -> https -> http
+                //     $e = new TransportException('The "'.$this->fileUrl.'" file could not be downloaded, not permitting protocol downgrade');
+                //     $e->setHeaders($http_response_header);
+                //     $e->setResponse($result);
+                //     throw $e;
+                // }
 
                 if ($this->io->isDebug()) {
                     $this->io->writeError(sprintf('Following redirect (%u)', $this->redirects));