change default value of dashboard_user and dashboard_pwd to empty string (#2383)

README.md

@@ -421,12 +421,12 @@ Configure a port for dashboard to enable this feature:
 ```ini
 [common]
 dashboard_port = 7500
-# dashboard's username and password are both optional，if not set, default is admin.
+# dashboard's username and password are both optional
 dashboard_user = admin
 dashboard_pwd = admin
 ```
 
-Then visit `http://[server_addr]:7500` to see the dashboard, with username and password both being `admin` by default.
+Then visit `http://[server_addr]:7500` to see the dashboard, with username and password both being `admin`.
 
 ![dashboard](/doc/pic/dashboard.png)
 
@@ -444,7 +444,7 @@ admin_user = admin
 admin_pwd = admin
 ```
 
-Then visit `http://127.0.0.1:7400` to see admin UI, with username and password both being `admin` by default.
+Then visit `http://127.0.0.1:7400` to see admin UI, with username and password both being `admin`.
 
 ### Monitor
 

pkg/config/client.go

@@ -68,10 +68,10 @@ type ClientCommonConf struct {
 	// is 0.
 	AdminPort int `ini:"admin_port" json:"admin_port"`
 	// AdminUser specifies the username that the admin server will use for
-	// login. By default, this value is "admin".
+	// login.
 	AdminUser string `ini:"admin_user" json:"admin_user"`
 	// AdminPwd specifies the password that the admin server will use for
-	// login. By default, this value is "admin".
+	// login.
 	AdminPwd string `ini:"admin_pwd" json:"admin_pwd"`
 	// AssetsDir specifies the local directory that the admin server will load
 	// resources from. If this value is "", assets will be loaded from the

pkg/config/server.go

@@ -72,10 +72,10 @@ type ServerCommonConf struct {
 	// 0.
 	DashboardPort int `ini:"dashboard_port" json:"dashboard_port"`
 	// DashboardUser specifies the username that the dashboard will use for
-	// login. By default, this value is "admin".
+	// login.
 	DashboardUser string `ini:"dashboard_user" json:"dashboard_user"`
-	// DashboardUser specifies the password that the dashboard will use for
-	// login. By default, this value is "admin".
+	// DashboardPwd specifies the password that the dashboard will use for
+	// login.
 	DashboardPwd string `ini:"dashboard_pwd" json:"dashboard_pwd"`
 	// EnablePrometheus will export prometheus metrics on {dashboard_addr}:{dashboard_port}
 	// in /metrics api.
@@ -181,8 +181,8 @@ func GetDefaultServerConf() ServerCommonConf {
 		VhostHTTPTimeout:       60,
 		DashboardAddr:          "0.0.0.0",
 		DashboardPort:          0,
-		DashboardUser:          "admin",
-		DashboardPwd:           "admin",
+		DashboardUser:          "",
+		DashboardPwd:           "",
 		EnablePrometheus:       false,
 		AssetsDir:              "",
 		LogFile:                "console",

pkg/config/server_test.go

@@ -180,8 +180,8 @@ func Test_LoadServerCommonConf(t *testing.T) {
 				ProxyBindAddr:          "0.0.0.9",
 				VhostHTTPTimeout:       60,
 				DashboardAddr:          "0.0.0.0",
-				DashboardUser:          "admin",
-				DashboardPwd:           "admin",
+				DashboardUser:          "",
+				DashboardPwd:           "",
 				EnablePrometheus:       false,
 				LogFile:                "console",
 				LogWay:                 "console",