Browse Source

Making texts consistent, removing possible injection vector

Mike van Riel 13 years ago
parent
commit
3197c391c1

+ 5 - 3
src/Packagist/WebBundle/Entity/PackageRepository.php

@@ -136,14 +136,16 @@ class PackageRepository extends EntityRepository
             ->orderBy('v.development', 'DESC')
             ->addOrderBy('v.releasedAt', 'DESC');
 
-        if (null !== $ids) {
-            $qb->where($qb->expr()->in('p.id', $ids));
-        }
         foreach ($filterFields as $name => $value) {
             $qb->andWhere('p.' . $name . ' = :' . $name);
         }
         $qb->setParameters($filterFields);
 
+        if (null !== $ids) {
+            $qb->where($qb->expr()->in('p.id', ':ids'))
+                ->setParameter('ids', $ids);
+        }
+
         return $qb->getQuery()->getResult();
     }
 

+ 1 - 1
src/Packagist/WebBundle/Resources/views/Web/type.html.twig

@@ -1,5 +1,5 @@
 {% extends "PackagistWebBundle:Web:list.html.twig" %}
 
 {% block content_title %}
-    <h1>Packages with type "{{ type }}"</h1>
+    <h1>Packages of type {{ type }}</h1>
 {% endblock %}