Browse Source

Improve Updater to not remove useful README titles

Javier Eguiluz 8 years ago
parent
commit
3ea99fe77d
1 changed files with 3 additions and 5 deletions
  1. 3 5
      src/Packagist/WebBundle/Package/Updater.php

+ 3 - 5
src/Packagist/WebBundle/Package/Updater.php

@@ -629,13 +629,11 @@ class Updater
             }
             }
         }
         }
 
 
-        // remove first title as it's usually the project name which we don't need
-        if ($dom->getElementsByTagName('h1')->length) {
+        // remove first page element if it's a h1, because it's usually the project
+        // name or the `README` string which we don't need
+        if ('h1' === $dom->childNodes->item(0)->nodeName) {
             $first = $dom->getElementsByTagName('h1')->item(0);
             $first = $dom->getElementsByTagName('h1')->item(0);
             $first->parentNode->removeChild($first);
             $first->parentNode->removeChild($first);
-        } elseif ($dom->getElementsByTagName('h2')->length) {
-            $first = $dom->getElementsByTagName('h2')->item(0);
-            $first->parentNode->removeChild($first);
         }
         }
 
 
         $readme = $dom->saveHTML();
         $readme = $dom->saveHTML();