Browse Source

Add user-generated-content flag on external links

Jordi Boggiano 5 years ago
parent
commit
9af3b4cb5b

+ 0 - 1
app/config/config_test.yml

@@ -18,7 +18,6 @@ swiftmailer:
     disable_delivery: true
 
 services:
-
     test.user_repo:
         alias: Packagist\WebBundle\Entity\UserRepository
         public: true

+ 1 - 1
src/Packagist/WebBundle/Package/Updater.php

@@ -656,7 +656,7 @@ class Updater
         // Links can not be trusted, mark them nofollow and convert relative to absolute links
         $links = $dom->getElementsByTagName('a');
         foreach ($links as $link) {
-            $link->setAttribute('rel', 'nofollow noindex noopener external');
+            $link->setAttribute('rel', 'nofollow noindex noopener external ugc');
             if ('#' === substr($link->getAttribute('href'), 0, 1)) {
                 $link->setAttribute('href', '#user-content-'.substr($link->getAttribute('href'), 1));
             } elseif ('mailto:' === substr($link->getAttribute('href'), 0, 7)) {

+ 1 - 1
src/Packagist/WebBundle/Resources/views/package/version_details.html.twig

@@ -42,7 +42,7 @@
             {% for author in version.authorData %}
                 <li>
                     {%- if author.homepage|default(false) -%}
-                        <a rel="nofollow noopener external noindex" href="{{ author.homepage }}">{{ author.name }}</a>
+                        <a rel="nofollow noopener external noindex ugc" href="{{ author.homepage }}">{{ author.name }}</a>
                     {%- else -%}
                         {{ author.name }}
                     {%- endif -%}

+ 10 - 10
src/Packagist/WebBundle/Resources/views/package/view_package.html.twig

@@ -146,28 +146,28 @@
                             </p>
 
                             {% if version and version.homepage %}
-                                <p><a rel="nofollow noopener external noindex" href="{{ version.homepage }}">Homepage</a></p>
+                                <p><a rel="nofollow noopener external noindex ugc" href="{{ version.homepage }}">Homepage</a></p>
                             {% endif %}
                             {% if version.support.source is defined %}
-                                <p><a rel="nofollow noopener external noindex" href="{{ version.support.source }}">Source</a></p>
+                                <p><a rel="nofollow noopener external noindex ugc" href="{{ version.support.source }}">Source</a></p>
                             {% endif %}
                             {% if version and version.support.issues is defined %}
-                                <p><a rel="nofollow noopener external noindex" href="{{ version.support.issues }}">Issues</a></p>
+                                <p><a rel="nofollow noopener external noindex ugc" href="{{ version.support.issues }}">Issues</a></p>
                             {% endif %}
                             {% if version and version.support.irc is defined %}
-                                <p><a rel="nofollow noopener external noindex" href="{{ version.support.irc }}">IRC</a></p>
+                                <p><a rel="nofollow noopener external noindex ugc" href="{{ version.support.irc }}">IRC</a></p>
                             {% endif %}
                             {% if version and version.support.chat is defined %}
-                                <p><a rel="nofollow noopener external noindex" href="{{ version.support.chat }}">Chat</a></p>
+                                <p><a rel="nofollow noopener external noindex ugc" href="{{ version.support.chat }}">Chat</a></p>
                             {% endif %}
                             {% if version and version.support.forum is defined %}
-                                <p><a rel="nofollow noopener external noindex" href="{{ version.support.forum }}">Forum</a></p>
+                                <p><a rel="nofollow noopener external noindex ugc" href="{{ version.support.forum }}">Forum</a></p>
                             {% endif %}
                             {% if version and version.support.wiki is defined %}
-                                <p><a rel="nofollow noopener external noindex" href="{{ version.support.wiki }}">Wiki</a></p>
+                                <p><a rel="nofollow noopener external noindex ugc" href="{{ version.support.wiki }}">Wiki</a></p>
                             {% endif %}
                             {% if version and version.support.docs is defined %}
-                                <p><a rel="nofollow noopener external noindex" href="{{ version.support.docs }}">Documentation</a></p>
+                                <p><a rel="nofollow noopener external noindex ugc" href="{{ version.support.docs }}">Documentation</a></p>
                             {% endif %}
                         </div>
 
@@ -176,7 +176,7 @@
                                 <p>
                                     Fund package maintenance!
                                     {% for fundingOption in version.funding %}
-                                        <br><a rel="nofollow noopener external noindex" href="{{ fundingOption.url }}">
+                                        <br><a rel="nofollow noopener external noindex ugc" href="{{ fundingOption.url }}">
                                             {% set fundingType = fundingOption.type|default('custom') %}
                                             {% if fundingType == 'custom' %}
                                                 <i class="glyphicon glyphicon-link"></i>{{ fundingOption.url|replace({'http://': '', 'https://': ''})|trim('/') }}
@@ -247,7 +247,7 @@
                             {% if version and version.support is not null and version.support.issues is defined and version.support.issues starts with 'https://github.com/' and version.support.issues starts with repoUrl %}
                                 <p>
                                     <span>
-                                        <a rel="nofollow noopener external noindex" href="{{ version.support.issues }}">Open Issues</a>:
+                                        <a rel="nofollow noopener external noindex ugc" href="{{ version.support.issues }}">Open Issues</a>:
                                     </span>
                                     {{ package.gitHubOpenIssues|number_format(0, '.', '&#8201;')|raw }}
                                 </p>