Browse Source

Fix comments from code review

Mike van Riel 12 years ago
parent
commit
9d3bb4f53b

+ 6 - 6
src/Packagist/WebBundle/Controller/WebController.php

@@ -400,14 +400,14 @@ class WebController extends Controller
         $version = $repo->getFullVersion($versionId);
         $package = $version->getPackage();
 
-        $is_maintainer    = $package->getMaintainers()->contains($this->getUser());
-        $may_edit_package = $this->get('security.context')->isGranted('ROLE_EDIT_PACKAGES');
+        $isMaintainer   = $package->getMaintainers()->contains($this->getUser());
+        $mayEditPackage = $this->get('security.context')->isGranted('ROLE_EDIT_PACKAGES');
 
         $html = $this->renderView(
             'PackagistWebBundle:Web:versionDetails.html.twig',
             array(
                 'version'    => $version,
-                'may_delete' => $is_maintainer || $may_edit_package,
+                'mayDelete' => $isMaintainer || $mayEditPackage,
             )
         );
 
@@ -432,10 +432,10 @@ class WebController extends Controller
         $version = $repo->getFullVersion($versionId);
         $package = $version->getPackage();
 
-        $is_maintainer    = $package->getMaintainers()->contains($this->getUser());
-        $may_edit_package = $this->get('security.context')->isGranted('ROLE_EDIT_PACKAGES');
+        $isMaintainer   = $package->getMaintainers()->contains($this->getUser());
+        $mayEditPackage = $this->get('security.context')->isGranted('ROLE_EDIT_PACKAGES');
 
-        if (!$is_maintainer || !$$may_edit_package) {
+        if (!$isMaintainer || !$mayEditPackage) {
             throw new AccessDeniedException;
         }
 

+ 1 - 1
src/Packagist/WebBundle/Resources/views/Web/versionDetails.html.twig

@@ -1,6 +1,6 @@
 {% import "PackagistWebBundle::macros.html.twig" as packagist %}
 
-{% if may_delete is defined and may_delete %}
+{% if mayDelete is defined and mayDelete %}
 <form class="action" action="{{ path("delete_version", {"versionId": version.id}) }}" method="post">
     <input type="hidden" name="_method" value="DELETE" />
     <input type="submit" value="Delete">