Browse Source

Fix tests and avoid static state, refs #625

Jordi Boggiano 9 years ago
parent
commit
b89e360a6a
1 changed files with 3 additions and 4 deletions
  1. 3 4
      src/Packagist/WebBundle/Model/DownloadManager.php

+ 3 - 4
src/Packagist/WebBundle/Model/DownloadManager.php

@@ -21,8 +21,8 @@ use Predis\Client;
  */
  */
 class DownloadManager
 class DownloadManager
 {
 {
-
     protected $redis;
     protected $redis;
+    protected $redisCommandLoaded = false;
 
 
     public function __construct(Client $redis)
     public function __construct(Client $redis)
     {
     {
@@ -114,12 +114,11 @@ class DownloadManager
      */
      */
     public function addDownload($package, $version)
     public function addDownload($package, $version)
     {
     {
-        static $loaded = false;
         $redis = $this->redis;
         $redis = $this->redis;
 
 
-        if (!$loaded) {
+        if (!$this->redisCommandLoaded) {
             $redis->getProfile()->defineCommand('downloadsIncr', 'Packagist\Redis\DownloadsIncr');
             $redis->getProfile()->defineCommand('downloadsIncr', 'Packagist\Redis\DownloadsIncr');
-            $loaded = true;
+            $this->redisCommandLoaded = true;
         }
         }
 
 
         if ($package instanceof Package) {
         if ($package instanceof Package) {