Ver Fonte

Avoid reading childNodes property if we get an empty first element

Jordi Boggiano há 7 anos atrás
pai
commit
dad7c16c7e
1 ficheiros alterados com 4 adições e 1 exclusões
  1. 4 1
      src/Packagist/WebBundle/Package/Updater.php

+ 4 - 1
src/Packagist/WebBundle/Package/Updater.php

@@ -639,7 +639,10 @@ class Updater
 
 
         // remove first page element if it's a <h1> or <h2>, because it's usually
         // remove first page element if it's a <h1> or <h2>, because it's usually
         // the project name or the `README` string which we don't need
         // the project name or the `README` string which we don't need
-        $first = $dom->getElementsByTagName('body')->item(0)->childNodes->item(0);
+        $first = $dom->getElementsByTagName('body')->item(0);
+        if ($first) {
+            $first = $first->childNodes->item(0);
+        }
 
 
         if ($first && ('h1' === $first->nodeName || 'h2' === $first->nodeName)) {
         if ($first && ('h1' === $first->nodeName || 'h2' === $first->nodeName)) {
             $first->parentNode->removeChild($first);
             $first->parentNode->removeChild($first);