Browse Source

Do not parse response to MSETNX into boolean value.

Daniele Alessandri 9 năm trước cách đây
mục cha
commit
38fafb22ba

+ 0 - 8
src/Command/StringSetMultiplePreserve.php

@@ -24,12 +24,4 @@ class StringSetMultiplePreserve extends StringSetMultiple
     {
         return 'MSETNX';
     }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function parseResponse($data)
-    {
-        return (bool) $data;
-    }
 }

+ 4 - 3
tests/Predis/Command/StringSetMultiplePreserveTest.php

@@ -66,7 +66,8 @@ class StringSetMultiplePreserveTest extends PredisCommandTestCase
      */
     public function testParseResponse()
     {
-        $this->assertSame(true, $this->getCommand()->parseResponse(true));
+        $this->assertSame(0, $this->getCommand()->parseResponse(0));
+        $this->assertSame(1, $this->getCommand()->parseResponse(1));
     }
 
     /**
@@ -76,7 +77,7 @@ class StringSetMultiplePreserveTest extends PredisCommandTestCase
     {
         $redis = $this->getClient();
 
-        $this->assertTrue($redis->msetnx('foo', 'bar', 'hoge', 'piyo'));
+        $this->assertSame(1, $redis->msetnx('foo', 'bar', 'hoge', 'piyo'));
         $this->assertSame('bar', $redis->get('foo'));
         $this->assertSame('piyo', $redis->get('hoge'));
     }
@@ -90,7 +91,7 @@ class StringSetMultiplePreserveTest extends PredisCommandTestCase
 
         $redis->set('foo', 'bar');
 
-        $this->assertFalse($redis->msetnx('foo', 'barbar', 'hoge', 'piyo'));
+        $this->assertSame(0, $redis->msetnx('foo', 'barbar', 'hoge', 'piyo'));
         $this->assertSame('bar', $redis->get('foo'));
         $this->assertSame(0, $redis->exists('hoge'));
     }