Browse Source

ZSetReverseRange now inherits from ZSetRange as the two commands share the same behaviour. This change allowed us to remove some code duplication.

Daniele Alessandri 15 years ago
parent
commit
51710682c7
1 changed files with 1 additions and 14 deletions
  1. 1 14
      lib/Predis.php

+ 1 - 14
lib/Predis.php

@@ -1231,21 +1231,8 @@ class ZSetRange extends \Predis\InlineCommand {
     }
 }
 
-class ZSetReverseRange extends \Predis\InlineCommand {
+class ZSetReverseRange extends \Predis\Commands\ZSetRange {
     public function getCommandId() { return 'ZREVRANGE'; }
-    public function parseResponse($data) {
-        $arguments = $this->getArguments();
-        if (count($arguments) === 4) {
-            if (strtolower($arguments[3]) === 'withscores') {
-                $result = array();
-                for ($i = 0; $i < count($data); $i++) {
-                    $result[] = array($data[$i], $data[++$i]);
-                }
-                return $result;
-            }
-        }
-        return $data;
-    }
 }
 
 class ZSetRangeByScore extends \Predis\InlineCommand {