Pārlūkot izejas kodu

Remove useless method.

It is better to wrap explicitly a multibulk response iterator into a
multibulk tuple response iterator instead of hard-coding that into a
specialized method.
Daniele Alessandri 10 gadi atpakaļ
vecāks
revīzija
a32eaf627b

+ 0 - 10
src/Response/Iterator/MultiBulk.php

@@ -74,14 +74,4 @@ class MultiBulk extends MultiBulkIterator
     {
         return $this->connection->read();
     }
-
-    /**
-     * Returns an iterator that reads a multi-bulk response as a list of tuples.
-     *
-     * @return MultiBulkTuple
-     */
-    public function asTuple()
-    {
-        return new MultiBulkTuple($this);
-    }
 }

+ 0 - 12
tests/Predis/Response/Iterator/MultiBulkTest.php

@@ -49,18 +49,6 @@ class MultiBulkTest extends PredisTestCase
         $this->assertEquals('PONG', $client->ping());
     }
 
-    /**
-     * @group connected
-     */
-    public function testIterableMultibulkCanBeWrappedAsTupleIterator()
-    {
-        $client = $this->getClient();
-        $client->mset('foo', 'bar', 'hoge', 'piyo');
-
-        $this->assertInstanceOf('Predis\Response\Iterator\MultiBulk', $iterator = $client->mget('foo', 'bar'));
-        $this->assertInstanceOf('Predis\Response\Iterator\MultiBulkTuple', $iterator->asTuple());
-    }
-
     /**
      * @group connected
      */

+ 4 - 2
tests/Predis/Response/Iterator/MultiBulkTupleTest.php

@@ -56,7 +56,9 @@ class MultiBulkTupleTest extends PredisTestCase
         $client = $this->getClient();
         $client->zadd('metavars', 1, 'foo', 2, 'hoge', 3, 'lol');
 
-        $this->assertInstanceOf('OuterIterator', $iterator = $client->zrange('metavars', 0, -1, 'withscores')->asTuple());
+        $iterator = new MultiBulkTuple($client->zrange('metavars', 0, -1, 'withscores'));
+
+        $this->assertInstanceOf('OuterIterator', $iterator);
         $this->assertInstanceOf('Predis\Response\Iterator\MultiBulkTuple', $iterator);
         $this->assertInstanceOf('Predis\Response\Iterator\MultiBulk', $iterator->getInnerIterator());
         $this->assertTrue($iterator->valid());
@@ -85,7 +87,7 @@ class MultiBulkTupleTest extends PredisTestCase
         $client = $this->getClient();
         $client->zadd('metavars', 1, 'foo', 2, 'hoge', 3, 'lol');
 
-        $iterator = $client->zrange('metavars', 0, -1, 'withscores')->asTuple();
+        $iterator = new MultiBulkTuple($client->zrange('metavars', 0, -1, 'withscores'));
 
         unset($iterator);