Quellcode durchsuchen

Remove useless default NULL value in method arguments.

Daniele Alessandri vor 12 Jahren
Ursprung
Commit
be46ab813c
2 geänderte Dateien mit 4 neuen und 10 gelöschten Zeilen
  1. 2 4
      lib/Predis/Connection/PredisCluster.php
  2. 2 6
      lib/Predis/Connection/RedisCluster.php

+ 2 - 4
lib/Predis/Connection/PredisCluster.php

@@ -143,11 +143,9 @@ class PredisCluster implements ClusterConnectionInterface, \IteratorAggregate, \
     /**
      * {@inheritdoc}
      */
-    public function getConnectionById($id = null)
+    public function getConnectionById($connectionId)
     {
-        $alias = $id ?: 0;
-
-        return isset($this->pool[$alias]) ? $this->pool[$alias] : null;
+        return isset($this->pool[$connectionId]) ? $this->pool[$connectionId] : null;
     }
 
     /**

+ 2 - 6
lib/Predis/Connection/RedisCluster.php

@@ -228,13 +228,9 @@ class RedisCluster implements ClusterConnectionInterface, \IteratorAggregate, \C
     /**
      * {@inheritdoc}
      */
-    public function getConnectionById($id = null)
+    public function getConnectionById($connectionId)
     {
-        if (!isset($id)) {
-            throw new \InvalidArgumentException("A valid connection ID must be specified");
-        }
-
-        return isset($this->pool[$id]) ? $this->pool[$id] : null;
+        return isset($this->pool[$connectionId]) ? $this->pool[$connectionId] : null;
     }
 
     /**