Bladeren bron

Do not parse response to SISMEMBER into boolean value.

Daniele Alessandri 9 jaren geleden
bovenliggende
commit
e531d39f53
2 gewijzigde bestanden met toevoegingen van 5 en 13 verwijderingen
  1. 0 8
      src/Command/SetIsMember.php
  2. 5 5
      tests/Predis/Command/SetIsMemberTest.php

+ 0 - 8
src/Command/SetIsMember.php

@@ -24,12 +24,4 @@ class SetIsMember extends Command
     {
         return 'SISMEMBER';
     }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function parseResponse($data)
-    {
-        return (bool) $data;
-    }
 }

+ 5 - 5
tests/Predis/Command/SetIsMemberTest.php

@@ -54,8 +54,8 @@ class SetIsMemberTest extends PredisCommandTestCase
     {
         $command = $this->getCommand();
 
-        $this->assertTrue($command->parseResponse(1));
-        $this->assertFalse($command->parseResponse(0));
+        $this->assertSame(0, $command->parseResponse(0));
+        $this->assertSame(1, $command->parseResponse(1));
     }
 
     /**
@@ -67,8 +67,8 @@ class SetIsMemberTest extends PredisCommandTestCase
 
         $redis->sadd('letters', 'a', 'b', 'c');
 
-        $this->assertTrue($redis->sismember('letters', 'a'));
-        $this->assertFalse($redis->sismember('letters', 'z'));
+        $this->assertSame(1, $redis->sismember('letters', 'a'));
+        $this->assertSame(0, $redis->sismember('letters', 'z'));
     }
 
     /**
@@ -78,7 +78,7 @@ class SetIsMemberTest extends PredisCommandTestCase
     {
         $redis = $this->getClient();
 
-        $this->assertFalse($redis->sismember('letters', 'a'));
+        $this->assertSame(0, $redis->sismember('letters', 'a'));
     }
 
     /**